Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react,styles): add breadcrumb component #502

Merged
merged 5 commits into from
Jan 11, 2022
Merged

feat(react,styles): add breadcrumb component #502

merged 5 commits into from
Jan 11, 2022

Conversation

scurker
Copy link
Member

@scurker scurker commented Jan 7, 2022

this is needed for #488

two column component with breadcrumb in the header

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Preview branch generated at https://breadcrumb.d1gko6en628vir.amplifyapp.com

schne324
schne324 previously requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be setting aria-current="page" or aria-current="location"

some great examples here: https://scottaohara.github.io/a11y_breadcrumbs/

@scurker
Copy link
Member Author

scurker commented Jan 9, 2022

we should be setting aria-current="page" or aria-current="location"

some great examples here: https://scottaohara.github.io/a11y_breadcrumbs/

That wasn't my interpretation of the practices from wai-aria:

The link to the current page has aria-current set to page. If the element representing the current page is not a link, aria-current is optional.

I quickly threw this together because it's a part of Aaron's design but wasn't sure how it was exactly going to be used. I'm not sure if we can always assume if the breadcrumb will be a link, but we can bring it up for discussion next week.

@scurker scurker merged commit b917da5 into develop Jan 11, 2022
@scurker scurker deleted the breadcrumb branch January 11, 2022 20:56
@github-actions
Copy link
Contributor

Preview branch generated at https://breadcrumb.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schne324 schne324 schne324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scurker @schne324