Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct dialog content padding according to design #447

Merged
merged 1 commit into from
Dec 8, 2021
Merged

fix: Correct dialog content padding according to design #447

merged 1 commit into from
Dec 8, 2021

Conversation

dequejosie
Copy link
Contributor

@dequejosie dequejosie commented Dec 8, 2021 •
edited
Loading

This will only affect dialogs with a fixed height

Screen Shot 2021-12-08 at 2 08 34 PM

Screen Shot 2021-12-08 at 2 08 43 PM

Screen Shot 2021-12-08 at 2 08 55 PM

Screen Shot 2021-12-08 at 2 09 04 PM

@dequejosie dequejosie merged commit b21ec32 into develop Dec 8, 2021
@dequejosie dequejosie deleted the change-dialog-content-padding branch December 8, 2021 19:23
stephenmathieson added a commit that referenced this pull request Dec 8, 2021
@stephenmathieson
Merge branch 'develop' into add-axe-core-tests
cbbc2ba 
* develop:
  fix: Correct dialog content padding according to design (#447)
  fix: remove unused background color for disabled select (#446)
  fix: render null instead of false in empty cases (#443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dequejosie @stephenmathieson