Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow TableHeader to take th attributes and TableCell to take td attributes #444

Merged
merged 1 commit into from
Dec 8, 2021
Merged

fix: allow TableHeader to take th attributes and TableCell to take td attributes #444

merged 1 commit into from
Dec 8, 2021

Conversation

thuey
Copy link
Collaborator

@thuey thuey commented Dec 8, 2021

Currently, the way the types are set up, we can't set any attributes on TableHeader or TableCell except className. We should be able to set things like scope and colspan.

We've had to set TableHeader to any to get around this: https://github.com/dequelabs/walnut/pull/2042/files#diff-c0d076ba97b24a2d7584c89ff60baf472ce1e33c4b9399c3c3b9befac61527b6R23

Related: #288

@thuey thuey requested a review from a team December 8, 2021 05:40
@thuey thuey merged commit 8523174 into develop Dec 8, 2021
@thuey thuey deleted the update-th-td-interface branch December 8, 2021 21:35
stephenmathieson added a commit that referenced this pull request Dec 14, 2021
@stephenmathieson
Merge branch 'develop' into add-axe-core-tests
756bfe0 
* develop:
  feat(react): add onChange prop to tabs when the active tab changes (#453)
  feat: make IconButton polymorphic through 'as' prop (#452)
  fix(Step): Add an accessible name when using `tooltip={...}` (#449)
  fix: allow TableHeader to take th attributes and TableCell to take td attributes (#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thuey @scurker