Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): gives skip nav a unique accessible name #439

Merged
merged 2 commits into from
Dec 3, 2021
Merged

fix(docs): gives skip nav a unique accessible name #439

merged 2 commits into from
Dec 3, 2021

Conversation

schne324
Copy link
Member

@schne324 schne324 commented Dec 2, 2021 •
edited
Loading

resolves 1 issue type for the new a11y tests (#386):

Ensures landmarks are unique

VO readout:

Link, skip to Main Content, Skip, navigation

Link, skip to Main Content, Skip, navigation

ever so slightly redundant but resolve an axe-core issue by giving this navigation element a unique accessible name

@schne324 schne324 requested a review from a team December 2, 2021 23:43
scurker
scurker previously approved these changes Dec 3, 2021
View reviewed changes
@schne324 schne324 requested a review from scurker December 3, 2021 16:07
@schne324 schne324 merged commit b96841e into develop Dec 3, 2021
@schne324 schne324 deleted the skip-name branch December 3, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker Awaiting requested review from scurker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schne324 @scurker