Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Address component #434

Merged
merged 5 commits into from
Nov 24, 2021
Merged

feat: add Address component #434

merged 5 commits into from
Nov 24, 2021

Conversation

thuey
Copy link
Collaborator

@thuey thuey commented Nov 23, 2021

Add a set of Address components for https://github.com/dequelabs/walnut/issues/2488

Dark Theme

image

Light Theme

image

@thuey thuey marked this pull request as ready for review November 23, 2021 18:16
@thuey thuey requested a review from a team November 23, 2021 18:16
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor TypeScript nits. Otherwise LGTM!

@stephenmathieson
Copy link
Member

It would be nice if we had some bottom padding on the demo pages, as the Netlify tool bar truncates the page.

demo page truncated

@thuey thuey merged commit 1470cc3 into develop Nov 24, 2021
@thuey thuey deleted the address-component branch November 24, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants