-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): updates onChange prop to be optional #390
Conversation
yarn.lock
Outdated
@@ -3129,6 +3129,13 @@ create-hmac@^1.1.0, create-hmac@^1.1.2, create-hmac@^1.1.4: | |||
safe-buffer "^5.0.1" | |||
sha.js "^2.4.8" | |||
|
|||
cross-env@^7.0.3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this diff seems weird but I remember you told me yesterday that there were agora deps checked into source? I'm not seeing those removed here...I'm also not seeing any agora deps in the yarn.lock
in the develop branch either 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were from my initial commit. I removed them by uninstalling and reinstalling the cross-env package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had my Deque npmrc pointed to agora when I checked in the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this patch doesn't update any deps but has yarn.lock diffs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schne324 - I reverted the yarn.lock
changes that were caused by my DQ .npmrc config. I will need a re-thumb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not gonna hold this up for some yarn.lock nonsense...ideally we'd back those changes out though 🤷
onChange
prop to be optionalCloses issue: #389