fix(Icon): Support intellisense for type= prop
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a build step which dynamically creates our list of `<Icon>` types. This enables intellisense and prevents us from having to manually edit the demo page. Closes #281
scurker
reviewed
Oct 13, 2021
Comment on lines
+14
to
+21
| const ICONS_WITH_DIRECTIONS = [ | ||
| 'arrow', | ||
| 'arrow-circle', | ||
| 'chevron', | ||
| 'chevron-double', | ||
| 'triangle' | ||
| ]; | ||
| const DIRECTIONS = ['up', 'down', 'left', 'right']; |
There was a problem hiding this comment.
In theory, any icon could have a direction since it's just a modifier. I don't have strong opinions here since these are all the icons that make sense to have directions, we would just need to remember to add them when adding new icons. 🤷
There was a problem hiding this comment.
I don't like that we'll have to remember to add them here either. The only other option (which you've alluded to) is allowing direction modifiers on all icons. Not sure it makes sense to do type="pencil-down' though 🤷
Happy to do whatever y'all think is best here.
There was a problem hiding this comment.
I don't think it's worth holding up the PR over, so I'm going to approve and then see if @schne324 objects.
scurker
approved these changes
Oct 13, 2021
schne324
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a build step which dynamically creates our list of
<Icon>types. This enables intellisense and prevents us from having to manually edit the demo page.Closes #281