feat: Implement dark theme for Select and TextField #366
Conversation
|
Haven't had a chance to review the code changes, but I just looked at the deploy preview and it looks like the text field (including multiline) has the wrong font color set:
The uxpin documents the color as |
| } | ||
|
|
||
| .cauldron--theme-dark input, | ||
| select, |
There was a problem hiding this comment.
Are we intentionally applying styles to all <select> elements here? IMO Cauldron should only style elements it renders.
There was a problem hiding this comment.
Good question. The code has been there and I was assuming that it only affects Cauldron components, but now I think about it. It probably will affects these native elements outside Cauldron too, no? @schne324
There was a problem hiding this comment.
@stephenmathieson is correct - cauldron should only style its components. Given that this was already there, I'm cool if we want to address this issue in a separate PR
There was a problem hiding this comment.
Digging deeper, this file is full of cauldron styles that'd apply to non-cauldron components (see https://github.com/dequelabs/cauldron/pull/366/files#diff-d2f5588b0cde6a6cbe8f128481e2f436d72c46d49ecd4a507c36b28f001a9b6dR34-R42
There was a problem hiding this comment.
☝️ more of a reason to address this issue separately
There was a problem hiding this comment.
Created an issue for this
Should solve this issue: https://github.com/dequelabs/axe-extension/pull/1879