Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): Adds theme provider #292

Merged
merged 2 commits into from
Jul 23, 2021
Merged

feat(react): Adds theme provider #292

merged 2 commits into from
Jul 23, 2021

Conversation

schne324
Copy link
Member

@schne324 schne324 commented Jul 22, 2021 •
edited
Loading

resolves #283

@schne324 schne324 requested review from scurker and dequejosie July 22, 2021 16:07
scurker
scurker previously requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@scurker scurker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for different context values or that the class gets correctly set for the provided/default context.

@schne324 schne324 dismissed scurker’s stale review July 22, 2021 17:58

adding missing tests

@schne324 schne324 requested a review from scurker July 22, 2021 17:58
@schne324 schne324 merged commit d34ee25 into develop Jul 23, 2021
@schne324 schne324 deleted the theme-provider branch July 23, 2021 15:00
@scurker scurker mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

@dequejosie dequejosie Awaiting requested review from dequejosie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for simple switching between light and dark modes
2 participants
@schne324 @scurker