Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): allows radio's icon to be appear checked (icon) #207

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

schne324
Copy link
Member

@schne324 schne324 commented Mar 20, 2021

resolves #208

@schne324 schne324 requested a review from scurker March 20, 2021 02:57
@@ -18,6 +18,7 @@ const Icon = forwardRef<HTMLDivElement, IconProps>(
const [IconSVG, setIcon] = useState<React.ComponentType<any> | null>(null);

useEffect(() => {
isMounted.current = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, interesting 👀

@schne324 schne324 merged commit e2a2f8a into develop Mar 21, 2021
@schne324 schne324 deleted the rad-radios branch March 30, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadioGroup is broken
2 participants