fix(react): remove unsupported props for alert component #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously requested changes
Jan 29, 2021
There was a problem hiding this comment.
The demo site currently uses these props and suggests to users that they should/can:
- https://github.com/dequelabs/cauldron/blob/develop/docs/patterns/components/Alert/index.js#L30
- https://github.com/dequelabs/cauldron/blob/develop/docs/patterns/components/Alert/index.js#L44
- https://github.com/dequelabs/cauldron/blob/develop/docs/patterns/components/Alert/index.js#L79
- https://github.com/dequelabs/cauldron/blob/develop/docs/patterns/components/Alert/index.js#L93
We should either remove them from the documentation site or leave them.
Also this is a duplicate of #171 (I forgot to pick this back up/finish it).
Ah frick, forgot to check demo. This could've been caught if the demo site was in typescript. 🤦 |
schne324
approved these changes
Jul 28, 2021
|
🎉 this means we can finally tag v1 🎊 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #105