Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): remove height/width styles from Icon #172

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

scurker
Copy link
Member

@scurker scurker commented Jan 14, 2021

We shouldn't apply inherit styles to icon as consumers may want to size them differently. Individual components that use Icons should be able to freely override their sizes.

@scurker scurker requested a review from a team January 14, 2021 15:43
@scurker scurker merged commit 006fcbf into develop Jan 14, 2021
@scurker scurker deleted the icon-sizing branch January 14, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants