-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input Description / Error Text #1641
Comments
I have a fix for this, but I'm not sure I have permission to push up a PR. |
Hey @amberfrontend 👋 I believe you should have permissions to create a PR, but it might need to be from a fork. If that doesn't work let me know and I can double check the contributor settings. |
Hi @scurker I'm sorry for the delay. I was busy and then sick for a bit. I'm unable to submit a PR with a fork, either. Do you have a bit more detail about your contributing process (permissions, SSR or HTTPS, etc)? I'd love to contribute to Cauldron. |
@amberfrontend I'd like to help but I'm not sure I know how to help. We've had outside contributors contribute from a fork before (such as this one: #1464). I checked our contributor settings and it should still allow for outside contributors. Are there any errors or issues that you are seeing that you can share? |
@ezirlingerDQ What's the expected scenario when the label text needs to wrap? |
TextField
should accept a new optionaldescription
property that is displayed immediately below the label text. Whendescription
is present, the associated input field should havearia-describedby
with an idref pointing to the associated description.Note
When both
description
anderror
are set, thearia-describedby
property should reference the description idref first, followed by the error idref.Related Components
Designs
When the "label text" overflows with the "required" label, the label should wrap onto a new line without interfering with the placement or sizing of required.
Interface
Additional Changes
With this change, the placement of the error message should also be visually located immediately above the input field with the addition of a
caution
icon preceding the error text.The Required text should not have any font styles applied and have italics removed.
The text was updated successfully, but these errors were encountered: