fix: synced Notice component with design
#1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
denysfedorov
changed the title
Notice component with design
scurker
requested changes
Aug 1, 2024
There was a problem hiding this comment.
This is a good start! I left some inline comments but noticed a few other things. It looks like we need some additional CSS to handle lists as the margins of the list aren't offset correctly:
One other thing I missed is that we need to remove font-size so it inherits from the default font size of the body as well.
|
@scurker Fixed review changes, fixed mdx file, fixed lists view (margin\padding) |
|
|
denysfedorov
force-pushed
the
fix/design-sync-notice
branch
from
a9ae301 to
85b8aaa
Compare
scurker
reviewed
Aug 2, 2024
scurker
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1577