Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set value rather than label when using onChange and onSelectionChange with Combobox #1500

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: set value rather than label when using onChange and onSelectionChange with Combobox #1500

merged 2 commits into from
Jun 3, 2024

Conversation

yhafez
Copy link
Contributor

@yhafez yhafez commented Jun 3, 2024

Closes #1499

@yhafez yhafez requested a review from a team as a code owner June 3, 2024 18:44
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1500.d15792l1n26ww3.amplifyapp.com

scurker
scurker approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@yhafez yhafez merged commit 9defe04 into develop Jun 3, 2024
8 checks passed
@yhafez yhafez deleted the combobox-value-bug branch June 3, 2024 19:03
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yhafez @scurker