Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): consolidate polymorphic types to allow for better typehints and code linting when using polymorphic components #1414

Merged
merged 16 commits into from
Mar 18, 2024

Conversation

scurker
Copy link
Member

@scurker scurker commented Mar 15, 2024

closes #1407

…nts and code linting when using polymorphic components
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1414.d15792l1n26ww3.amplifyapp.com

@scurker scurker changed the title feat(react): consolidate polymorphic types to allow for better typehints and code linting when using polymorphic components fix(react): consolidate polymorphic types to allow for better typehints and code linting when using polymorphic components Mar 15, 2024
@scurker scurker marked this pull request as ready for review March 15, 2024 19:59
@scurker scurker requested a review from a team as a code owner March 15, 2024 19:59
@scurker scurker requested a review from a team March 15, 2024 20:59
@scurker scurker merged commit 2fa4aa0 into develop Mar 18, 2024
7 checks passed
@scurker scurker deleted the polymorphic-types-fix branch March 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support Polymorphic Components with as prop
2 participants