Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react,styles): add SearchField and internal TextFieldWrapper components #1372

Merged
merged 49 commits into from
Mar 4, 2024

Conversation

yhafez
Copy link
Contributor

@yhafez yhafez commented Feb 28, 2024

Closes #1190
Closes #1178

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1372.d15792l1n26ww3.amplifyapp.com

@yhafez yhafez marked this pull request as ready for review February 29, 2024 00:44
@yhafez yhafez requested review from a team as code owners February 29, 2024 00:44
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhafez this is looking really good! Most of the comments are just bringing things in alignment with the rest of Cauldron's conventions, but this has a great foundation, good work!

@shawnsharpDQ
Copy link

shawnsharpDQ commented Feb 29, 2024

Could we remove the margin on the right next to the clear button?
Search with text and remove button visable

The clear button needs to have a 24px hit area and I think it is measuring close to 14px

@scurker
Copy link
Member

scurker commented Feb 29, 2024

The clear button needs to have a 24px hit area and I think it is measuring close to 14px

The x to clear the field is coming from chrome ui and is not Cauldron. The mechanism for 24px also accounts for spacing, which means we need to account for the input field to be spaced appropriately, which it is not currently:

To be clear, a target can be under 24px and still pass minimum target size as long as there are no adjacent targets within that target. Since this is part of browser chrome that we can't customize the sizing, we need to be sure that the spacing passes instead.

scurker
scurker previously requested changes Mar 1, 2024
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nit picks and things to bring things up to alignment with other cauldron components.

Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking into one last thing, the intermediate variables don't seem to be getting applied so I'm trying to dig into why that's not happening. But in the meantime, a few last cleanup things.

@scurker scurker changed the title feat: add SearchField and internal TextFieldWrapper components feat(react,styles): add SearchField and internal TextFieldWrapper components Mar 4, 2024
scurker
scurker previously requested changes Mar 4, 2024
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice Work!

@yhafez yhafez merged commit 46b16a1 into develop Mar 4, 2024
6 checks passed
@yhafez yhafez deleted the search-field branch March 4, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search Field Placeholder text has default styling
4 participants