-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react,styles): add SearchField and internal TextFieldWrapper components #1372
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yhafez this is looking really good! Most of the comments are just bringing things in alignment with the rest of Cauldron's conventions, but this has a great foundation, good work!
packages/react/src/components/internal/TextFieldWrapper/TextFieldWrapper.test.tsx
Outdated
Show resolved
Hide resolved
The x to clear the field is coming from chrome ui and is not Cauldron. The mechanism for 24px also accounts for spacing, which means we need to account for the input field to be spaced appropriately, which it is not currently: To be clear, a target can be under 24px and still pass minimum target size as long as there are no adjacent targets within that target. Since this is part of browser chrome that we can't customize the sizing, we need to be sure that the spacing passes instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nit picks and things to bring things up to alignment with other cauldron components.
packages/react/src/components/internal/TextFieldWrapper/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into one last thing, the intermediate variables don't seem to be getting applied so I'm trying to dig into why that's not happening. But in the meantime, a few last cleanup things.
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice Work!
Closes #1190
Closes #1178