-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): set 300px width wrapper around textfields #130
Conversation
Hello Cauldron team! Myself and @noahcoop are contributing to this project as an assignment for UM. Looking forward to hearing your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 there's just one minor thing needing to be addressed
👍 thanks for the contribution! The change looks good I just need to figure out why circleci isn't running in this branch. I will get this merged once I sort that out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the back-and-forth. I completely overlooked the fact that you updated the actual react component rather than just the demo app. You should update the TextField documentation/demo component instead of packages/react/src/components/TextField/index.tsx
because we intentionally leave our inputs at 100% without a max width container to make them work in various contexts.
I think all you'll need to do is back out the changes to .TextField form {
max-width: 300px;
} |
c7a2f28
to
f70fbae
Compare
Awesome, no worries re the back-and-forth. Just reverted the changes and updated the docs css |
Reviewed for security (gh action still isn't working) |
Issue resolution for #87