Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): set 300px width wrapper around textfields #130

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

noahcoop
Copy link
Contributor

@noahcoop noahcoop commented Dec 2, 2020

Issue resolution for #87

@allisonkench
Copy link

Hello Cauldron team! Myself and @noahcoop are contributing to this project as an assignment for UM. Looking forward to hearing your feedback!

Copy link
Member

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 there's just one minor thing needing to be addressed

@schne324 schne324 changed the title Fix all textfields to 300px width fix(docs): set 300px width wrapper around textfields Dec 8, 2020
@schne324
Copy link
Member

schne324 commented Dec 8, 2020

👍 thanks for the contribution! The change looks good I just need to figure out why circleci isn't running in this branch. I will get this merged once I sort that out

Copy link
Member

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back-and-forth. I completely overlooked the fact that you updated the actual react component rather than just the demo app. You should update the TextField documentation/demo component instead of packages/react/src/components/TextField/index.tsx because we intentionally leave our inputs at 100% without a max width container to make them work in various contexts.

@schne324
Copy link
Member

schne324 commented Dec 9, 2020

You should update the TextField documentation/demo component instead of packages/react/src/components/TextField/index.tsx

I think all you'll need to do is back out the changes to packages/react/src/components/TextField/index.tsx and update the css to:

.TextField form {
  max-width: 300px;
}

@noahcoop noahcoop force-pushed the text-field-container branch from c7a2f28 to f70fbae Compare December 9, 2020 17:47
@noahcoop
Copy link
Contributor Author

noahcoop commented Dec 9, 2020

Awesome, no worries re the back-and-forth. Just reverted the changes and updated the docs css

@schne324
Copy link
Member

Reviewed for security (gh action still isn't working)

@schne324 schne324 merged commit 5222427 into dequelabs:develop Dec 11, 2020
@erik-deque erik-deque mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants