Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix bug where Error class changes are applied globally #1131

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

yhafez
Copy link
Contributor

@yhafez yhafez commented Jul 27, 2023

Relates to bug noted in this Slack thread

Reverts changes to Error class styles, and scopes new changes to their respective elements

@yhafez yhafez requested a review from a team as a code owner July 27, 2023 18:26
@github-actions
Copy link
Contributor

Preview branch generated at https://revert-error-styles.d1gko6en628vir.amplifyapp.com

@scurker scurker changed the title fix(Styles): fix bug where Error class changes are applied globally fix(styles): fix bug where Error class changes are applied globally Jul 27, 2023
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of other spots that we also need to fix:

cauldron select component with invalid padding/border

cauldron textfield component with invalid padding/border

@scurker scurker dismissed their stale review July 27, 2023 19:11

reviewed

@scurker scurker merged commit bb3ed29 into develop Jul 27, 2023
@scurker scurker deleted the revert-error-styles branch July 27, 2023 19:11
@github-actions
Copy link
Contributor

Preview branch generated at https://revert-error-styles.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants