Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): cache_keys regexp ordered #331

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

darkweak
Copy link
Owner

Closes #329

@darkweak
Copy link
Owner Author

@frederichoule this PR will fix the unordered cache_keys.

@frederichoule
Copy link
Contributor

Great, I'll try it. Since it didn't work I'm now using matchers on Caddy directly to match different query string to different caching parameters, but I'll give it a try as soon as it's released.

@darkweak
Copy link
Owner Author

darkweak commented Mar 24, 2023

@frederichoule of course! 😉

@darkweak darkweak force-pushed the feat/chore/cache_keys/ordered-regexp branch from 06bb57c to 9e60c37 Compare March 27, 2023 07:08
@darkweak darkweak force-pushed the feat/chore/cache_keys/ordered-regexp branch from 66193c9 to 6edf47f Compare March 27, 2023 08:37
@frederichoule frederichoule mentioned this pull request Mar 27, 2023
@darkweak darkweak added bug Something isn't working enhancement New feature or request Next release It will be in the next release labels Mar 28, 2023
@darkweak darkweak self-assigned this Mar 28, 2023
This was linked to issues Mar 28, 2023
@darkweak darkweak force-pushed the feat/chore/cache_keys/ordered-regexp branch from 074dcaa to dd24b8e Compare March 28, 2023 18:46
@darkweak darkweak merged commit 195397f into master Mar 29, 2023
@frederichoule
Copy link
Contributor

Good job @darkweak ! Can you bump up version in https://github.com/caddyserver/cache-handler also? Thanks!

@darkweak darkweak deleted the feat/chore/cache_keys/ordered-regexp branch April 24, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Next release It will be in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache_keys order cache_keys + default hide souin on traefik 3.0
2 participants