Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise validation error on mismatched name #97

Merged
merged 4 commits into from
Jan 10, 2022
Merged

fix: raise validation error on mismatched name #97

merged 4 commits into from
Jan 10, 2022

Conversation

satra
Copy link
Member

@satra satra commented Nov 9, 2021

closes #96

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #97 (8d1a5e4) into master (435fc13) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   96.41%   96.35%   -0.06%     
==========================================
  Files          16       16              
  Lines        1449     1453       +4     
==========================================
+ Hits         1397     1400       +3     
- Misses         52       53       +1     
Flag Coverage Δ
unittests 96.35% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/consts.py 100.00% <100.00%> (ø)
dandischema/models.py 94.24% <100.00%> (ø)
dandischema/tests/test_metadata.py 100.00% <100.00%> (ø)
dandischema/tests/test_models.py 95.55% <100.00%> (+0.07%) ⬆️
dandischema/metadata.py 96.63% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435fc13...8d1a5e4. Read the comment docs.

@satra satra merged commit 7e53e9f into master Jan 10, 2022
@satra satra deleted the fix/pattern branch January 10, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail validation for empty contact person field
1 participant