fix: associate schema key with schemas for older versions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 96.30% 96.33% +0.02%
==========================================
Files 16 16
Lines 1407 1417 +10
==========================================
+ Hits 1355 1365 +10
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
satra
added
patch
yarikoptic
reviewed
Oct 2, 2021
dandischema/metadata.py
Outdated
| "PublishedDandiset": "published-dandiset", | ||
| "Asset": "asset", | ||
| "PublishedAsset": "published-asset", | ||
| } |
There was a problem hiding this comment.
Later (away from laptop ATM) we should centralize (the same dict should be used there) with with https://github.com/dandi/dandischema/blob/master/dandischema/metadata.py#L90
There was a problem hiding this comment.
FWIW -- pushed quick RF to "centralize" in 4484597
yarikoptic
approved these changes
Oct 2, 2021
In principle could be "computed", but at this scale "dict" would be just fine
dchiquito
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes that only dandiset.json was being used for json validation when schema version of the object did not match current schema.