Better exception classes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are now two different exceptions, `JsonschemaValidationError` and `PydanticValidationError`, to better communicate the difference between the two validation modes. This makes it much easier to consume errors, since the two validators produce errors in vastly different shapes.
I don't see a purpose to wrapping the exception in a list, and it makes consuming the error more difficult.
dchiquito
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 89.47% 94.96% +5.48%
==========================================
Files 14 16 +2
Lines 1378 1490 +112
==========================================
+ Hits 1233 1415 +182
+ Misses 145 75 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yarikoptic
reviewed
Sep 27, 2021
yarikoptic
approved these changes
Sep 28, 2021
| @@ -113,9 +113,9 @@ def _validate_obj_json(data, schema, missing_ok=False): | |||
| for error in sorted(validator.iter_errors(data), key=str): | |||
| if missing_ok and "is a required property" in error.message: | |||
| continue | |||
| error_list.append([error]) | |||
| error_list.append(error) | |||
|
thank you @dchiquito , looks kosher to me, so let's proceed... and let's release right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some difficulty parsing the exceptions being thrown now that I need to differentiate between pydantic and jsonschema validation errors. This PR should mitigate that pain a bit.
Not a blocker, but nice to have in the future.