Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds all properties to context with implicit dandi schema #84

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

satra
Copy link
Member

@satra satra commented Sep 21, 2021

supercedes #73

@surchs - this PR incorporates the changes in #77 and then extends it to address the namespace issue. i did not include explicit namespace in this PR.

  • adds all properties to context
  • adds test to ensure there is no conflict

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #84 (d07f57d) into master (e91ccfb) will increase coverage by 0.03%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   89.44%   89.47%   +0.03%     
==========================================
  Files          14       14              
  Lines        1355     1378      +23     
==========================================
+ Hits         1212     1233      +21     
- Misses        143      145       +2     
Flag Coverage Δ
unittests 89.47% <93.54%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/tests/test_models.py 95.23% <90.90%> (-0.66%) ⬇️
dandischema/metadata.py 96.90% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91ccfb...d07f57d. Read the comment docs.

@surchs
Copy link

surchs commented Sep 22, 2021

Thanks @satra for the ping and really sorry I didn't manage to help with this in in time - I got swamped. I had a look and I think this will be very helpful to continue playing with the jsonld of the dandisets in the future. I'll give it a try.

@satra
Copy link
Member Author

satra commented Sep 22, 2021

@surchs - thanks. i'm going to merge this in and we can evolve the schema in the future.

@yarikoptic - i can label this for release, unless we want to get any other things in. and perhaps test out the schema with vjsf before release to make sure that bit works. that's something we don't have any automation on.

@satra satra merged commit dcc0ed5 into master Sep 23, 2021
@satra satra deleted the enh/nskey branch September 23, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants