Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NC license #83

Merged
merged 1 commit into from
Sep 15, 2021
Merged

remove NC license #83

merged 1 commit into from
Sep 15, 2021

Conversation

satra
Copy link
Member

@satra satra commented Sep 15, 2021

this should remove NC license, which should not allow validation for any dandiset still remaining with the license. this updates the schema version as well.

@satra satra added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 15, 2021
@satra satra requested a review from yarikoptic September 15, 2021 01:36
@satra
Copy link
Member Author

satra commented Sep 15, 2021

@yarikoptic - i'm thinking of getting this out there before the bigger migration PR.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #83 (5e45fcc) into master (6a88930) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          13       13           
  Lines        1318     1318           
=======================================
  Hits         1188     1188           
  Misses        130      130           
Flag Coverage Δ
unittests 90.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/model_types.py 100.00% <ø> (ø)
dandischema/tests/test_models.py 95.80% <ø> (ø)
dandischema/consts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a88930...5e45fcc. Read the comment docs.

@yarikoptic yarikoptic merged commit fff6455 into master Sep 15, 2021
@yarikoptic yarikoptic deleted the fix/license branch September 15, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants