-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] creating identifier from url in relatedResource #78
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 90.13% 89.19% -0.95%
==========================================
Files 13 13
Lines 1318 1342 +24
==========================================
+ Hits 1188 1197 +9
- Misses 130 145 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bendichter -pinging |
@djarecka I don't know if there are any dandisets with improperly formatted DOIs. I think I fixed them manually so that publication could go through. You could try this yourself though. See if it works on e.g. http://purl.obolibrary.org/obo/UBERON_0001384 |
wasn't sure how to use the website here, but I added some basic unit tests. |
I've modified
to_datacite
, so it should try to get DOI identifier from identifier that has form of url.I'm using some assumption about doi from
odf.io
andbiorxiv.org
, not sure if they are always right...@bendichter - could you point me to datasets/metadata that I could test this fix.
addresses issue from
dandiarchive
: dandi/dandiarchive-legacy#843