Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] creating identifier from url in relatedResource #78

Merged
merged 7 commits into from
Sep 21, 2021

Conversation

djarecka
Copy link
Member

I've modified to_datacite, so it should try to get DOI identifier from identifier that has form of url.

I'm using some assumption about doi from odf.io and biorxiv.org, not sure if they are always right...

@bendichter - could you point me to datasets/metadata that I could test this fix.

addresses issue from dandiarchive: dandi/dandiarchive-legacy#843

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #78 (c98996f) into master (3696446) will decrease coverage by 0.94%.
The diff coverage is 36.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   90.13%   89.19%   -0.95%     
==========================================
  Files          13       13              
  Lines        1318     1342      +24     
==========================================
+ Hits         1188     1197       +9     
- Misses        130      145      +15     
Flag Coverage Δ
unittests 89.19% <36.95%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/datacite.py 51.40% <0.00%> (-4.73%) ⬇️
dandischema/tests/test_datacite.py 46.51% <54.83%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3696446...c98996f. Read the comment docs.

@djarecka
Copy link
Member Author

@bendichter -pinging

@bendichter
Copy link
Member

@djarecka I don't know if there are any dandisets with improperly formatted DOIs. I think I fixed them manually so that publication could go through. You could try this yourself though. See if it works on e.g. http://purl.obolibrary.org/obo/UBERON_0001384

@djarecka
Copy link
Member Author

wasn't sure how to use the website here, but I added some basic unit tests.

@satra satra merged commit 7d89226 into dandi:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants