Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datacite publish argument #70

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Datacite publish argument #70

merged 2 commits into from
Jul 29, 2021

Conversation

dchiquito
Copy link
Contributor

This is only partially tested, since the data isn't actually sent off to the test server. If we were to do that in a test, we would accumulate findable and undeletable(?) DOIs.

@yarikoptic I invite followup commits with more comprehensive testing.

@dchiquito dchiquito requested review from yarikoptic and satra July 29, 2021 17:31
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #70 (1f57445) into master (192ca1f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   96.02%   96.05%   +0.03%     
==========================================
  Files          13       13              
  Lines        1309     1319      +10     
==========================================
+ Hits         1257     1267      +10     
  Misses         52       52              
Flag Coverage Δ
unittests 96.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/datacite.py 94.89% <100.00%> (+0.10%) ⬆️
dandischema/tests/test_datacite.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192ca1f...1f57445. Read the comment docs.

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 29, 2021
@yarikoptic
Copy link
Member

Added labels, all green now. I would've preferred avoiding copy pasting data structures across tests and come up with reusable scenarios (otherwise harder to spot relevant code/data) but that I guess could be done later. Let's proceed and release library so could be put to use

@yarikoptic yarikoptic merged commit 774e928 into master Jul 29, 2021
@yarikoptic yarikoptic deleted the datacite-publish-argument branch July 29, 2021 17:46
@yarikoptic
Copy link
Member

If we were to do that in a test, we would accumulate findable and undeletable(?) DOIs.

FWIW at least in webui indeed "Delete" button in the menu on the left is not available for "Findable" DOIs like https://doi.test.datacite.org/dois/10.80507%2F000003%2F0.210401.2020, but present for "Draft", like https://doi.test.datacite.org/dois/10.80507%2Fdandi.000035%2F0.210729.1456 . Didn't try via API, and indeed we would not want to keep breeding DOIs (even in the test. instance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants