Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DANDI_ALLOW_LOCALHOST_URLS when running dandi-cli tests #66

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 27, 2021

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Jul 27, 2021
@jwodder jwodder marked this pull request as draft July 27, 2021 13:17
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #66 (4c285de) into master (fc37096) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          13       13           
  Lines        1274     1274           
=======================================
  Hits         1224     1224           
  Misses         50       50           
Flag Coverage Δ
unittests 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc37096...4c285de. Read the comment docs.

@jwodder jwodder marked this pull request as ready for review July 27, 2021 13:31
@yarikoptic
Copy link
Member

Let's proceed with this, thank you @jwodder. For longer term solution, filed #67

@yarikoptic yarikoptic merged commit 2a7919e into master Jul 27, 2021
@yarikoptic yarikoptic deleted the localhost branch July 27, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants