-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a generic DOI site instead of 10.80507 #65
Conversation
10.80507 is our test DOI site, we need to support both that and our production site, 10.48324.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 13 13
Lines 1274 1274
=======================================
Hits 1224 1224
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
IIRC we already merged some breaking changes (newer version of schema) in master. I think this PR might be a waking call to establish a dedicated branch to accumulate breaking changes (eg 'next') while leaving master to be ready to be released any moment. |
@yarikoptic - yup - that's why i wanted to chat. |
What about:
gotchas might come in changelog generation after we do merge |
this PR will also require a schema version change, so before we implement a full blown refactor, we may try to cut a release to 0.5.0 with the other PR in tow before we fully implement validation against multiple schemas. |
Co-authored-by: Satrajit Ghosh <[email protected]>
10.80507 is our test DOI site, we need to support both that and our
production site, 10.48324.