Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF(CI): run dandi-cli tests only against 3.8 (but all OSes) #64

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

yarikoptic
Copy link
Member

ATM we really overwhelm dandischema PRs with reports from dandi-cli.
I think it will be sufficient to just test against a single python version
at least for now

@yarikoptic yarikoptic requested a review from jwodder July 21, 2021 14:48
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #64 (26b279a) into master (7e8fc41) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          13       13           
  Lines        1274     1274           
=======================================
  Hits         1224     1224           
  Misses         50       50           
Flag Coverage Δ
unittests 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8fc41...26b279a. Read the comment docs.

@jwodder
Copy link
Member

jwodder commented Jul 21, 2021

@yarikoptic You may want to also change the python: 3.7 on lines 35 and 39 to python: 3.8.

@yarikoptic
Copy link
Member Author

thank you @jwodder -- force-pushed.

ATM we really overwhelm dandischema PRs with reports from dandi-cli.
I think it will be sufficient to just test against a single python version
at least for now
@yarikoptic yarikoptic added the tests Add or improve existing tests label Jul 21, 2021
@satra satra merged commit fc37096 into master Jul 21, 2021
@satra satra deleted the rf-less-cli-tests branch July 21, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants