Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dandi-cli tests with dandi-api image built with local version of dandischema #63

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 21, 2021

Closes #62.

@jwodder jwodder added the tests Add or improve existing tests label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #63 (b38c8a4) into master (3f30ea5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          13       13           
  Lines        1274     1274           
=======================================
  Hits         1224     1224           
  Misses         50       50           
Flag Coverage Δ
unittests 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f30ea5...b38c8a4. Read the comment docs.

@yarikoptic
Copy link
Member

Wow CI is so green! The only fail is on windows:

_________ test_dandimeta_datacite[additional_meta2-datacite_checks2] __________
dandischema\tests\test_datacite.py:300: in test_dandimeta_datacite
    datacite_post(datacite, meta_dict["doi"])
dandischema\tests\test_datacite.py:28: in datacite_post
    rp.raise_for_status()
C:\hostedtoolcache\windows\Python\3.9.6\x64\lib\site-packages\requests\models.py:953: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://api.test.datacite.org/dois

----------- coverage: platform win32, python 3.9.6-final-0 -----------
Coverage XML written to file coverage.xml

which I will rerun to see if it was a fluke or something in composition of the request to datacite on windows somehow "flips it"?

@yarikoptic
Copy link
Member

and now it is green -- so was some fluke... we might need to guard against it or figure out what it is really if it reemerges. Let's proceed!

@yarikoptic yarikoptic merged commit 7e8fc41 into master Jul 21, 2021
@yarikoptic yarikoptic deleted the gh-62 branch July 21, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dandi-cli tests run against dandi-api which uses this branch/PR version of dandischema
2 participants