Switch to versioningit (non-src-layout) #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 96.05% 86.72% -9.34%
==========================================
Files 13 13
Lines 1319 1273 -46
==========================================
- Hits 1267 1104 -163
- Misses 52 169 +117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| # Same format as versioneer | ||
| distance = "{version}+{distance}.{vcs}{rev}" | ||
| dirty = "{version}+{distance}.{vcs}{rev}.dirty" | ||
| distance-dirty = "{version}+{distance}.{vcs}{rev}.dirty" |
There was a problem hiding this comment.
since it would be a common usecase AFAIK -- why versiongit doesn't just default to it (and also for above default-version which sounds like something to be within the same config section IMHO) and thus not require all this boilerplate in every project?
There was a problem hiding this comment.
versioningit already has a default set of formats (listed at the end of this section). I just gave different ones here so that the versioning would continue to be consistent with versioneer. As for default-version, that's for recovering from errors, which I believe the default response to should be the installer failing.
| @@ -1,10 +1,25 @@ | |||
| [build-system] | |||
| # Setuptools version should match setup.py; wheel because pip will insert it noisily | |||
| requires = ["setuptools >= 38.3.0", "wheel"] | |||
| requires = ["setuptools >= 42.0.0", "versioningit ~= 0.1.0", "wheel"] | |||
There was a problem hiding this comment.
FWIW, didn't try yet, but looks really neat in that it indeed seems to avoid needing all the copied code etc as versioneer does. That though then makes projects rely on the 'stability' of versiongit but indeed ~= (or even == for paranoids) pinning should provide remedy
|
@satra WDYT -- should we give it a try? |
|
sure - let's try it out. |
|
sorry , this one fell off the radar. @jwodder - could you please rebase so we get a fresh sweep of testing, and then lets merge? |
|
I am sorry -- radar was still "off". Once more @jwodder and feel free to merge it if no CI errors can be coming from changes in the PR |
jwodder
force-pushed
the
versioningit2
branch
from
466de5c to
b1822bd
Compare
|
thank you @jwodder , all green, let's give it a shot! |
This is an alternative to #55 if you don't want to switch to a
src/layout.