Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change id to indentifier for software #46

Merged
merged 3 commits into from
Jul 6, 2021
Merged

fix: change id to indentifier for software #46

merged 3 commits into from
Jul 6, 2021

Conversation

satra
Copy link
Member

@satra satra commented Jun 25, 2021

an RRID can be associated with different versions, therefore cannot be used as the id of an object. this fixes this in a test.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #46 (4b34f36) into master (3608577) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          11       11           
  Lines        1042     1042           
=======================================
  Hits          999      999           
  Misses         43       43           
Flag Coverage Δ
unittests 95.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/tests/test_datacite.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3608577...4b34f36. Read the comment docs.

@waxlamp
Copy link
Member

waxlamp commented Jun 25, 2021

@satra, who is able to review this change? Could you nominate someone in the sidebar?

@satra satra requested a review from dchiquito June 25, 2021 13:38
@satra
Copy link
Member Author

satra commented Jun 25, 2021

@waxlamp - i added @dchiquito just because this is also related to the dandi/dandi-archive#364 PR.

this is a rather innocuous change for this repo. so not releasing a new version at this point.

@yarikoptic
Copy link
Member

@satra we still need this PR to be merged right? (hard to assess the necessity since tests seemed to be ok without it and with it here ;-)) your PR in dandi-api was superseded by dandi/dandi-archive#372 (merged already)

@satra
Copy link
Member Author

satra commented Jul 6, 2021

yes, this is more of a clarity PR than a test PR. i just merged with master. we can merge when tests pass.

@satra satra merged commit 4f6e708 into master Jul 6, 2021
@satra satra deleted the fix/softwareid branch July 6, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants