Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.yml: Use DANDI_GITHUB_TOKEN to push to repo #44

Merged
merged 1 commit into from
Jun 24, 2021
Merged

release.yml: Use DANDI_GITHUB_TOKEN to push to repo #44

merged 1 commit into from
Jun 24, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 24, 2021

Closes #43.

@jwodder jwodder added the internal Changes only affect the internal API label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #44 (bd3a69e) into master (004de55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          11       11           
  Lines        1021     1021           
=======================================
  Hits          978      978           
  Misses         43       43           
Flag Coverage Δ
unittests 95.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004de55...bd3a69e. Read the comment docs.

@satra
Copy link
Member

satra commented Jun 24, 2021

i think this may also need the git checkout and git ref update that was in the linked yaml

@satra
Copy link
Member

satra commented Jun 24, 2021

or we can test this by giving it a release + patch label first.

@jwodder
Copy link
Member Author

jwodder commented Jun 24, 2021

@satra Do you mean the git fetch --unshallow --tags? That's equivalent to passing with: {fetch-depth: 0} to the checkout action.

@satra
Copy link
Member

satra commented Jun 24, 2021

the section after that.

@jwodder
Copy link
Member Author

jwodder commented Jun 24, 2021

@satra The git config --local --unset should be taken care of by specifying token: ${{ secrets.DANDI_GITHUB_TOKEN }} when checking out.

@satra satra added release Create a release when this pr is merged patch Increment the patch version when merged labels Jun 24, 2021
@satra
Copy link
Member

satra commented Jun 24, 2021

ok let's check it out. i added the release + patch labels. merging now.

@satra satra merged commit 27ee019 into master Jun 24, 2021
@satra satra deleted the gh-43 branch June 24, 2021 16:13
@jwodder
Copy link
Member Author

jwodder commented Jun 24, 2021

@satra It failed because the 0.2.9 tag already exists from the last failed release.

@satra
Copy link
Member

satra commented Jun 24, 2021

just deleted it and triggering a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add branch protection rules and update auto config
2 participants