Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make assetsummary computable for dandisets with no assets #38

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

satra
Copy link
Member

@satra satra commented Jun 16, 2021

allows computing assetsummary for dandisets with no assets
changes assetmodel to allow for numberoffiles and bytes to be 0 till publish time.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #38 (a098b99) into master (b38ce14) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   95.75%   95.79%   +0.04%     
==========================================
  Files          11       11              
  Lines         965      975      +10     
==========================================
+ Hits          924      934      +10     
  Misses         41       41              
Flag Coverage Δ
unittests 95.79% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/consts.py 100.00% <100.00%> (ø)
dandischema/metadata.py 97.09% <100.00%> (+0.01%) ⬆️
dandischema/models.py 93.81% <100.00%> (+0.07%) ⬆️
dandischema/tests/test_metadata.py 100.00% <100.00%> (ø)
dandischema/tests/test_models.py 94.73% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e9ec3...a098b99. Read the comment docs.

@satra satra added patch Increment the patch version when merged release Create a release when this pr is merged labels Jun 16, 2021
@yarikoptic yarikoptic merged commit 0aff0b8 into master Jun 16, 2021
@yarikoptic yarikoptic deleted the fix/assetsSummary branch June 16, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants