Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove readOnly from constants #28

Merged
merged 3 commits into from
Jun 8, 2021
Merged

fix: remove readOnly from constants #28

merged 3 commits into from
Jun 8, 2021

Conversation

satra
Copy link
Member

@satra satra commented Jun 8, 2021

a fix to make us compatible with the vjsf component for meditor.

@satra satra added the minor Increment the minor version when merged label Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #28 (95e866a) into master (8c6a3e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   94.50%   94.52%   +0.01%     
==========================================
  Files          11       11              
  Lines         856      858       +2     
==========================================
+ Hits          809      811       +2     
  Misses         47       47              
Flag Coverage Δ
unittests 94.52% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/consts.py 100.00% <100.00%> (ø)
dandischema/models.py 91.87% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6a3e2...95e866a. Read the comment docs.

@satra
Copy link
Member Author

satra commented Jun 8, 2021

@yarikoptic - this does not change the models and only the schema. should we overwrite the schema or increase schema as well? the only thing this impacts is the meditor component.

@satra satra added the release Create a release when this pr is merged label Jun 8, 2021
@satra
Copy link
Member Author

satra commented Jun 8, 2021

bumped schema version anyway.

@waxlamp
Copy link
Member

waxlamp commented Jun 8, 2021

bumped schema version anyway.

I believe the patch level bump was appropriate and required in this case.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad to have similar minded zealots of versioning on the team @waxlamp ! ;-)

In general approve, but shouldn't we have just patch label on library then, instead of minor?

@satra satra added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Jun 8, 2021
@satra
Copy link
Member Author

satra commented Jun 8, 2021

yes, should be patch.

@satra satra merged commit 3006cb3 into master Jun 8, 2021
@satra satra deleted the fix/vjsf-jsonschema branch June 8, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants