-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove readOnly from constants #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 94.50% 94.52% +0.01%
==========================================
Files 11 11
Lines 856 858 +2
==========================================
+ Hits 809 811 +2
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@yarikoptic - this does not change the models and only the schema. should we overwrite the schema or increase schema as well? the only thing this impacts is the meditor component. |
bumped schema version anyway. |
I believe the patch level bump was appropriate and required in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am glad to have similar minded zealots of versioning on the team @waxlamp ! ;-)
In general approve, but shouldn't we have just patch label on library then, instead of minor?
yes, should be patch. |
a fix to make us compatible with the vjsf component for meditor.