fix: dandi-etag carries extra component beyond md5 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 93.93% 94.50% +0.57%
==========================================
Files 11 11
Lines 824 856 +32
==========================================
+ Hits 774 809 +35
+ Misses 50 47 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
satra
added
patch
yarikoptic
reviewed
May 28, 2021
| except (KeyError, ValueError): | ||
| raise ValueError("Digest must have both valid dandi-etag and sha2-256.") | ||
| digest = values[DigestType.dandi_etag] | ||
| if "-" not in digest or len(digest.split("-")[0]) != 32: |
There was a problem hiding this comment.
I think
Suggested change
| if "-" not in digest or len(digest.split("-")[0]) != 32: | |
| if len(digest.split("-")[0]) != 32: |
would be sufficient but ok either way
|
Left minor non-consequential comment which might be wrong, so let's proceed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for digest assumed an md5sum. however, the digest has an extra component and are of the form:
<md5sum>-<chunks>