Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up schema testing and autorelease of new schemata #17

Merged
merged 4 commits into from
May 26, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 26, 2021

Closes #2.

@jwodder jwodder added the tests Add or improve existing tests label May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #17 (1e5ddc5) into master (4ef0778) will increase coverage by 19.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   59.19%   79.10%   +19.91%     
===========================================
  Files           9       12        +3     
  Lines         941     1474      +533     
===========================================
+ Hits          557     1166      +609     
+ Misses        384      308       -76     
Flag Coverage Δ
unittests 79.10% <ø> (+19.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/utils.py 100.00% <0.00%> (ø)
dandischema/consts.py 100.00% <0.00%> (ø)
dandischema/__init__.py 100.00% <0.00%> (ø)
dandischema/model_types.py 100.00% <0.00%> (ø)
dandischema/tests/test_utils.py 100.00% <0.00%> (ø)
dandischema/datacite.py 93.82% <0.00%> (ø)
dandischema/tests/test_metadata.py 100.00% <0.00%> (ø)
dandischema/tests/test_datacite.py 100.00% <0.00%> (ø)
dandischema/_version.py 45.96% <0.00%> (+1.75%) ⬆️
dandischema/models.py 86.48% <0.00%> (+13.45%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef0778...1e5ddc5. Read the comment docs.

if ! git diff --cached --exit-code $dirs
then echo "[ERROR] Existing schema files modified instead of creating a new version"
exit 1
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upon the first occasion we need to fix this block, let's move it into some tools/ci/check_schemata_no_changes helper or alike

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass

pull_request:
# Run whenever labels are modified, in addition to normal events:
types: [opened, synchronize, reopened, labeled, unlabeled]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yarikoptic
Copy link
Member

fold versioneer fixing (#19 ) in here so we get a green light (I guess it is what trips pull_requests with known to us error message) ... if something else -- needs to be fixed up too I guess

@jwodder
Copy link
Member Author

jwodder commented May 26, 2021

@yarikoptic Do you mean that you want #19 to be part of this PR instead of a separate PR?

@yarikoptic
Copy link
Member

@yarikoptic Do you mean that you want #19 to be part of this PR instead of a separate PR?

that was my thinking since fixing outside would not be CI-tested. but I will leave it up to you -- can leave #19 on its own and merge, and rerun tests here

@yarikoptic
Copy link
Member

woohoo -- all green and coverage improved! Let's proceed. Thank you @jwodder !

@yarikoptic yarikoptic merged commit a65afe2 into master May 26, 2021
@yarikoptic yarikoptic deleted the gh-2 branch May 26, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow for releasing library [and schema]
2 participants