-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up schema testing and autorelease of new schemata #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
===========================================
+ Coverage 59.19% 79.10% +19.91%
===========================================
Files 9 12 +3
Lines 941 1474 +533
===========================================
+ Hits 557 1166 +609
+ Misses 384 308 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
if ! git diff --cached --exit-code $dirs | ||
then echo "[ERROR] Existing schema files modified instead of creating a new version" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upon the first occasion we need to fix this block, let's move it into some tools/ci/check_schemata_no_changes
helper or alike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass
pull_request: | ||
# Run whenever labels are modified, in addition to normal events: | ||
types: [opened, synchronize, reopened, labeled, unlabeled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
fold versioneer fixing (#19 ) in here so we get a green light (I guess it is what trips pull_requests with known to us error message) ... if something else -- needs to be fixed up too I guess |
@yarikoptic Do you mean that you want #19 to be part of this PR instead of a separate PR? |
that was my thinking since fixing outside would not be CI-tested. but I will leave it up to you -- can leave #19 on its own and merge, and rerun tests here |
woohoo -- all green and coverage improved! Let's proceed. Thank you @jwodder ! |
Closes #2.