feat: allow optionally controlled root #952

tylersayshi · 2024-10-06T04:05:35Z

Adds support for createRoot in createPages api and _root.tsx in fs-router mode for controlling the top level html and head tags

this will allow for controlling the top level tags, while still keeping a static default of the following:

    <html>
      <head></head>
      <body>{children}</body>
    </html>

vercel · 2024-10-06T04:05:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	Oct 7, 2024 1:08pm

codesandbox-ci · 2024-10-06T04:05:58Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

packages/waku/src/router/define-router.tsx

packages/waku/src/router/create-pages.ts

tylersayshi · 2024-10-06T06:46:06Z

@dai-shi do you know why pnpm install is failing on the CI checks? I can't see anything I might've changed... or maybe I'm misreading the logs, honestly unsure

dai-shi

1st review

e2e/fixtures/broken-links/src/pages/_layout.tsx

e2e/fixtures/ssg-wildcard/src/pages/_layout.tsx

examples/11_fs-router/src/pages/_root.tsx

packages/waku/src/lib/renderers/rsc-renderer.ts

packages/waku/src/router/common.ts

packages/waku/src/router/create-pages.ts

follow up to: #952 (comment) --------- Co-authored-by: Tyler <[email protected]>

dai-shi

LGTM

Merging this, but could you add a PR description? It would be nice if it's detailed.

dai-shi · 2024-10-08T08:25:14Z

e2e/fixtures/partial-build/src/pages/_root.tsx

+
+export const getConfig = async () => {
+  return {
+    render: 'static',


this is the default, right?

I wonder if we need _root.tsx for partial-build fixture. Is there any reason you created this file?

I created this just so that we had a test case that used the _root.tsx file.

If the presence of _root.tsx broke the build for any reason, having this here should catch that.

I'll update the description tho!

follow up to: dai-shi/waku#952 (comment) --------- Co-authored-by: Tyler <[email protected]>

vercel bot deployed to Preview October 6, 2024 04:06 View deployment

vercel bot had a problem deploying to Preview October 6, 2024 04:39 Failure

tylersayshi commented Oct 6, 2024

View reviewed changes

packages/waku/src/router/define-router.tsx Outdated Show resolved Hide resolved

tylersayshi force-pushed the feat/root branch from 30eebe8 to 62d9329 Compare October 6, 2024 05:23

vercel bot deployed to Preview October 6, 2024 05:24 View deployment

vercel bot deployed to Preview October 6, 2024 05:37 View deployment

tylersayshi force-pushed the feat/root branch from 24141d2 to 07b6e6b Compare October 6, 2024 05:44

vercel bot deployed to Preview October 6, 2024 05:45 View deployment

vercel bot deployed to Preview October 6, 2024 05:56 View deployment

dai-shi mentioned this pull request Oct 6, 2024

v1 Roadmap #24

Open

tylersayshi force-pushed the feat/root branch from 0545d9e to 6405a50 Compare October 6, 2024 06:04

vercel bot deployed to Preview October 6, 2024 06:04 View deployment

dai-shi reviewed Oct 6, 2024

View reviewed changes

packages/waku/src/router/create-pages.ts Outdated Show resolved Hide resolved

tylersayshi marked this pull request as ready for review October 6, 2024 06:15

vercel bot deployed to Preview October 6, 2024 06:15 View deployment

dai-shi reviewed Oct 6, 2024

View reviewed changes

tylersayshi force-pushed the feat/root branch from 632c244 to dcb26a9 Compare October 6, 2024 19:41

dai-shi reviewed Oct 7, 2024

View reviewed changes

packages/waku/src/router/create-pages.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 7, 2024 01:20 View deployment

vercel bot deployed to Preview October 7, 2024 01:30 View deployment

tylersayshi mentioned this pull request Oct 7, 2024

chore: lint for curly brackets and fix #956

Merged

tylersayshi added 6 commits October 6, 2024 18:48

feat: allow optionally controlled root

145df05

feat: add default root

77bebeb

fix: defaultroot from createElement

cd72e9e

chore: update some examples and remove clone

53da3e1

feat: handle _root.tsx

60779fc

chore: update tests and revert extension

403bb2a

tylersayshi added 6 commits October 6, 2024 18:50

fix: unstable skip for dynamic v render

ba8da0b

fix: from first review

929ccef

fix: remove unnecessary _layout's

3de6028

fix: remove extra title

8231fef

fix: add braces

b7b6dc2

fix: warn for renderEntries null

96be3b3

tylersayshi force-pushed the feat/root branch from 1043bcb to 96be3b3 Compare October 7, 2024 01:50

vercel bot deployed to Preview October 7, 2024 01:51 View deployment

fix: import type

ffc5a7c

tylersayshi force-pushed the feat/root branch from e5c9f99 to ffc5a7c Compare October 7, 2024 02:13

vercel bot deployed to Preview October 7, 2024 02:14 View deployment

dai-shi pushed a commit that referenced this pull request Oct 7, 2024

chore: lint for curly brackets and fix (#956)

94a05d6

follow up to: #952 (comment) --------- Co-authored-by: Tyler <[email protected]>

Merge branch 'main' into feat/root

ec68a01

vercel bot deployed to Preview October 7, 2024 13:08 View deployment

dai-shi approved these changes Oct 8, 2024

View reviewed changes

dai-shi merged commit 087d654 into dai-shi:main Oct 8, 2024
24 checks passed

yokos2 added a commit to yokos2/react-yoko-portfolio that referenced this pull request Feb 8, 2025

chore: lint for curly brackets and fix (#956)

26e159d

follow up to: dai-shi/waku#952 (comment) --------- Co-authored-by: Tyler <[email protected]>

HondaKazuhiro added a commit to HondaKazuhiro/waku that referenced this pull request Feb 12, 2025

chore: lint for curly brackets and fix (#956)

b480204

follow up to: dai-shi/waku#952 (comment) --------- Co-authored-by: Tyler <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow optionally controlled root #952

feat: allow optionally controlled root #952

tylersayshi commented Oct 6, 2024 •

edited

Loading

vercel bot commented Oct 6, 2024 •

edited

Loading

codesandbox-ci bot commented Oct 6, 2024 •

edited

Loading

tylersayshi commented Oct 6, 2024

dai-shi left a comment

dai-shi left a comment •

edited

Loading

dai-shi Oct 8, 2024

tylersayshi Oct 8, 2024

feat: allow optionally controlled root #952

feat: allow optionally controlled root #952

Conversation

tylersayshi commented Oct 6, 2024 • edited Loading

vercel bot commented Oct 6, 2024 • edited Loading

codesandbox-ci bot commented Oct 6, 2024 • edited Loading

tylersayshi commented Oct 6, 2024

dai-shi left a comment

Choose a reason for hiding this comment

dai-shi left a comment • edited Loading

Choose a reason for hiding this comment

dai-shi Oct 8, 2024

Choose a reason for hiding this comment

tylersayshi Oct 8, 2024

Choose a reason for hiding this comment

tylersayshi commented Oct 6, 2024 •

edited

Loading

vercel bot commented Oct 6, 2024 •

edited

Loading

codesandbox-ci bot commented Oct 6, 2024 •

edited

Loading

dai-shi left a comment •

edited

Loading