feat: honoEnhancer for Vercel, Deno and Netlify #941
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I confirmed Deno works. https://rm-waku-project-93w03wnv4zvw.deno.dev/api/hello My /about page has a few additions including printing the accept header pulled from the Hono context. https://rm-waku-project-93w03wnv4zvw.deno.dev/about Ignore the 404 error, that was part of a cloudflare test. I also deployed the cookies example without issue - Just need to test Netlify and Vercel now... |
|
I forgot about this PR 😬 I never tested with Vercel and Netlify... |
rmarscher
force-pushed
the
feat/honoEnhancer/vercelDenoNetlify
branch
from
90c3124 to
6d26c2c
Compare
|
Netlify works with the hono context - https://67335aaff9d5e608f01f7f2f--waku-project.netlify.app/about |
|
And Vercel works - https://waku-project2-34ob07khi-rob-marschers-projects.vercel.app/about OK. This PR is ready to merge. |
|
|
||
| const honoEnhancer = | ||
| (await configPromise).unstable_honoEnhancer || ((createApp) => createApp); | ||
| const app = honoEnhancer(createApp)(new Hono()); |
There was a problem hiding this comment.
Maybe we can do the same for vite-plugin-deploy-cloudflare.ts using top-level await.
Follow up to #923. I need to test these three but should be able to...