Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): avoid default startTransition #1257

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Feb 22, 2025

close #1255

  • add failing test
  • fix it

Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Feb 22, 2025 10:54am

Copy link

codesandbox-ci bot commented Feb 22, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Feb 22, 2025
@dai-shi dai-shi marked this pull request as ready for review February 22, 2025 10:53
Comment on lines +206 to +207
unstable_pending?: ReactNode;
unstable_notPending?: ReactNode;
Copy link
Owner Author

@dai-shi dai-shi Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is technically breaking but it's based on the fix. I haven't been confident with this lately, so I'm marking it as unstable.

@dai-shi dai-shi merged commit ff0cfd3 into main Feb 22, 2025
26 checks passed
@dai-shi dai-shi deleted the fix/dynamic-layout-with-suspense branch February 24, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Layouts with Suspense boundaries do not stream when changing pages
1 participant