feat(config): granular vite configs and React Compiler support #1102
Conversation
dai-shi
commented
Dec 28, 2024
•
dai-shi
commented
- refactor
- treeshake
- 'common'
- 41_type-alias
- 37_css 👉 FIXME
- ssr-basic (tsconfig)
- ssr-catch-error
- 05_compiler
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| export default defineConfig({ | ||
| unstable_viteConfigs: { | ||
| 'dev-main': getConfig, | ||
| 'dev-rsc': getConfig, | ||
| 'build-analyze': getConfig, | ||
| 'build-server': getConfig, | ||
| 'build-ssr': getConfig, | ||
| 'build-client': getConfig, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
would it make sense to have a "common" field that applies to the viteConfig in all environments/steps?
This seems like a good example for when that would be useful
@tylersayshi I need your help along with #1105 (comment). |
I'll have time to look tomorrow 👍 |
|
If the change from earlier today is blocking for 37_css could we try reverting to the other vote styled plugin to unblock for now? it seems like both plugins have issues, so we probably shouldn’t let this block us. |
I'm not sure. Maybe it's not related. I asked you because you should be more familiar. If another one works better, I'm fine about reverting too. |
|
Oh, this was much more challenging than I first expected. |
dai-shi
changed the title
for #1102 This reverts #1105 and reopens #750. Co-authored-by: Tyler <[email protected]>
