fix(create-pages): layouts missing with more nesting #1077
Conversation
Adds tests for layouts with nesting and slugs fixes dai-shi#1055
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
force-pushed
the
fix/layout-issues
branch
from
5549e2e to
31d7ba8
Compare
| // /nested/foo is defined as a staticPath of /nested/[id] which matches this layout | ||
| await page.goto(`http://localhost:${port}/nested/foo`); | ||
| await expect( | ||
| page.getByRole('heading', { name: 'Deeply Nested Layout' }), | ||
| ).toBeVisible(); | ||
|
|
There was a problem hiding this comment.
That was my bad too, but it's actually not a good idea to rely on examples. This is kind of historical reason, but we now have some standalone spec with fixtures.
Let's revisit it with a different PR later.
| path: PathWithoutSlug<Path>; | ||
| path: Path; |
There was a problem hiding this comment.
I'm not sure about this change, but count on you.
There was a problem hiding this comment.
without this change there is a type error if we attempt to define a layout for /foo/[id] which I think would be valid.
the fs router equivalent would be pages/foo/[id]/_layout.tsx
Adds tests for layouts with nesting and slugs
fixes #1055