Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename new_defineEntries to unstable_defineEntries and remove unused code #1066

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 14, 2024

following up #1043.

  • remove unused code
  • rename new_defineEntries
  • update docs

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 3:59am

Copy link

codesandbox-ci bot commented Dec 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi changed the title refactor: rename new_defineRouter to defineRouter and remove unused code refactor: rename new_defineEntries to defineEntries and remove unused code Dec 14, 2024
@dai-shi dai-shi changed the title refactor: rename new_defineEntries to defineEntries and remove unused code refactor: rename new_defineEntries to unstable_defineEntries and remove unused code Dec 14, 2024
@dai-shi dai-shi marked this pull request as ready for review December 14, 2024 03:59
@dai-shi dai-shi merged commit 4eb1bae into main Dec 14, 2024
26 checks passed
@dai-shi dai-shi deleted the rename-new-define-entries branch December 14, 2024 04:21
Comment on lines -94 to -96
if (buildData) {
unstable_getPlatformObject().buildData = buildData;
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to migrate this to new architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant