Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor unstable_defineRouter with new_defineEntries #1043

Merged
merged 18 commits into from
Dec 14, 2024
Merged

refactor unstable_defineRouter with new_defineEntries #1043

merged 18 commits into from
Dec 14, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 8, 2024 •
edited
Loading

Refactor unstable_defineRouter with new_defineEntries instead of defineEntries.

@vercel Vercel
Copy link

vercel bot commented Dec 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 14, 2024 0:53am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Dec 8, 2024
Open
@dai-shi dai-shi changed the title wip: refactor defineRouter with new_defineEntries wip: refactor unstable_defineRouter with new_defineEntries Dec 8, 2024
@tylersayshi
Copy link
Contributor

do you anticipate this needing changes to createPages? Or should everything work the same after this PR?

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 8, 2024

Everything should work without changing createPages. Otherwise, there's a bug...

@dai-shi dai-shi changed the title wip: refactor unstable_defineRouter with new_defineEntries refactor unstable_defineRouter with new_defineEntries Dec 10, 2024
@dai-shi dai-shi marked this pull request as ready for review December 10, 2024 01:31
@dai-shi
Copy link
Owner Author

dai-shi commented Dec 10, 2024

/canary-ci run

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 10, 2024

/canary-ci run

@dai-shi dai-shi merged commit 8a54eab into main Dec 14, 2024
26 checks passed
@dai-shi dai-shi deleted the unstable-define-router-with-new-define-entries branch December 14, 2024 01:20
@dai-shi dai-shi mentioned this pull request Dec 14, 2024
Merged
3 tasks
dai-shi added a commit that referenced this pull request Dec 14, 2024
@dai-shi
refactor: rename new_defineEntries to unstable_defineEntries and remo…
4eb1bae 
…ve unused code (#1066)

following up #1043.

- [x] remove unused code
- [x] rename new_defineEntries
- [x] update docs
@dai-shi dai-shi mentioned this pull request Dec 15, 2024
Merged
dai-shi added a commit that referenced this pull request Dec 15, 2024
@dai-shi
fix(define-router): context for build (#1071)
735b19b 
following up #1043.

If this doesn't work we need to look for completely alternative
approaches:
- bundle middleware in dist
- use custom ALS in define-router
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dai-shi @tylersayshi