Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): avoid configFile: false in vite config #1036

Merged
merged 3 commits into from
Dec 14, 2024
Merged

fix(dev): avoid configFile: false in vite config #1036

merged 3 commits into from
Dec 14, 2024

Conversation

kulkarnisaumitra98
Copy link
Contributor

@kulkarnisaumitra98 kulkarnisaumitra98 commented Dec 6, 2024 •
edited by dai-shi
Loading

close #953

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 14, 2024 0:07am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 6, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@kulkarnisaumitra98 kulkarnisaumitra98 mentioned this pull request Dec 6, 2024
Closed
@dai-shi
Copy link
Owner

dai-shi commented Dec 12, 2024

Sorry for the delay. I'll have a closer look later, perhaps after #1012.

@dai-shi
Copy link
Owner

dai-shi commented Dec 14, 2024

#1012 takes more time, so if this works now, it should be good.

@dai-shi dai-shi changed the title remove resolve config fix(dev): avoid mergeUserViteConfig Dec 14, 2024
@dai-shi dai-shi changed the title fix(dev): avoid mergeUserViteConfig fix(dev): avoid configFile: false in vite config Dec 14, 2024
@dai-shi dai-shi mentioned this pull request Dec 14, 2024
Open
@dai-shi dai-shi marked this pull request as ready for review December 14, 2024 00:24
@dai-shi
Copy link
Owner

dai-shi commented Dec 14, 2024

Looks like it's passing tests, and we have vite.config.ts in e2e fixtures (both normal & standalone).

dai-shi
dai-shi approved these changes Dec 14, 2024
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kulkarnisaumitra98 for looking into this.

I think there was some historical reason of preferring configFile: false, but it should be okay and if plugins depend on this field, it's unavoidable. Let's see how it goes. We will revisit processing vite configs in v0.22 anyway.

@dai-shi dai-shi merged commit 2d2d318 into dai-shi:main Dec 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [DEV only] waku app with vanilla-extract
2 participants
@kulkarnisaumitra98 @dai-shi