Fix for Misc elements issues #216 Item 1.a (Add cast utility that deals with indirect elements)

djowel · djowel · commit e8a76d367c3e · 2020-08-26T21:17:15.000+08:00
diff --git a/lib/src/element/menu.cpp b/lib/src/element/menu.cpp
@@ -7,6 +7,7 @@
 #include <elements/element/composite.hpp>
 #include <elements/element/traversal.hpp>
 #include <elements/element/port.hpp>
+#include <elements/element/traversal.hpp>
 
 namespace cycfi { namespace elements
 {
@@ -311,7 +312,7 @@ namespace cycfi { namespace elements
                         i += down? +1 : -1
                      )
                      {
-                        auto e = dynamic_cast<basic_menu_item_element*>(&c->at(i));
+                        auto e = find_element<basic_menu_item_element*>(&c->at(i));
                         if (e && e->is_enabled())
                         {
                            if (e == this)

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`#include <elements/element/composite.hpp>`
`8`	`8`	`#include <elements/element/traversal.hpp>`
`9`	`9`	`#include <elements/element/port.hpp>`
	`10`	`+#include <elements/element/traversal.hpp>`
`10`	`11`
`11`	`12`	`namespace cycfi { namespace elements`
`12`	`13`	`{`
`@@ -311,7 +312,7 @@ namespace cycfi { namespace elements`
`311`	`312`	`i += down? +1 : -1`
`312`	`313`	`)`
`313`	`314`	`{`
`314`		`- auto e = dynamic_cast<basic_menu_item_element*>(&c->at(i));`
	`315`	`+ auto e = find_element<basic_menu_item_element*>(&c->at(i));`
`315`	`316`	`if (e && e->is_enabled())`
`316`	`317`	`{`
`317`	`318`	`if (e == this)`