Fix for Misc elements issues #216 Item 7 (Warnings as errors)

Author: djowel

lib/CMakeLists.txt

@@ -178,9 +178,9 @@ endif()
 # Get rid of certain warnings, and make msvc support utf-8 without adding bom
 
 target_compile_options(elements PRIVATE
-   $<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -Wpedantic -ftemplate-backtrace-limit=0>
-   $<$<CXX_COMPILER_ID:Clang>:-Wall -Wpedantic -ftemplate-backtrace-limit=0>
-   $<$<CXX_COMPILER_ID:AppleClang>:-Wall -Wpedantic -ftemplate-backtrace-limit=0>
+   $<$<CXX_COMPILER_ID:GNU>:-Werror -Wall -Wextra -Wpedantic -ftemplate-backtrace-limit=0>
+   $<$<CXX_COMPILER_ID:Clang>:-Werror -Wall -Wpedantic -ftemplate-backtrace-limit=0>
+   $<$<CXX_COMPILER_ID:AppleClang>:-Werror -Wall -Wpedantic -ftemplate-backtrace-limit=0>
    $<$<CXX_COMPILER_ID:MSVC>:/W4 /wd4244 /wd4305 /wd4996 /wd4267 /wd4018 /utf-8>
 )
 
@@ -191,7 +191,7 @@ endif()
 
 if (APPLE)
    # Not sure why APPLE is not picking the target_compile_options above
-   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -ftemplate-backtrace-limit=0")
+   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra -Wpedantic -ftemplate-backtrace-limit=0")
 endif()
 
 ###############################################################################

lib/include/elements/element/slider.hpp

@@ -135,7 +135,7 @@ namespace cycfi { namespace elements
 
    template <size_t num_states>
    inline bool selector_base<num_states>::scroll(
-      context const& ctx, point dir, point p)
+      context const& /* ctx */, point /* dir */, point /* p */)
    {
       // We don't allow selector move via the scroll wheel.
       return false;
@@ -185,7 +185,7 @@ namespace cycfi { namespace elements
 
    template <unsigned size>
    inline view_limits basic_thumb_element<size>
-      ::limits(basic_context const& ctx) const
+      ::limits(basic_context const& /* ctx */) const
    {
 	  auto pt = point{ float(size), float(size) };
 	  return view_limits{ pt, pt };
@@ -234,7 +234,7 @@ namespace cycfi { namespace elements
 
    template <unsigned size, bool vertical>
    inline view_limits basic_track_element<size, vertical>
-      ::limits(basic_context const& ctx) const
+      ::limits(basic_context const& /* ctx */) const
    {
 	  auto sz = float(size);
 	  auto min_length_ = float(min_length);