Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: add replication controller #212

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

Rakshith-R
Copy link
Member

@Rakshith-R Rakshith-R commented Aug 23, 2022

controller: add replication controller

This controller has been ported from
https://github.com/csi-addons/volume-replication-operator
with minimal changes required to suit
kubernetes-csi-addons design.

The main changes include:

  • tweaks to rbac (tested and trimmed down to necessary ones)
  • controller now communicates to sidecar
    instead of csi-driver
  • sends secret name & ns instead of
    secret data, this will be fed in
    by the sidecar. (client related parameter changes)

Resolves: #116

Signed-off-by: Rakshith R [email protected]
Signed-off-by: Madhu Rajanna [email protected]
Signed-off-by: Humble Chirammal [email protected]
Signed-off-by: matancarmeli7 [email protected]
Signed-off-by: Raghavendra Talur [email protected]
Signed-off-by: Santosh Pillai [email protected]
Signed-off-by: Nitin Goyal [email protected]
Signed-off-by: Umanga Chapagain [email protected]
Signed-off-by: Shyamsundar Ranganathan [email protected]


  • secret.go and strings.go were no longer needed and deleted.
  • client communication is done using internal replication proto instead of csi-addons spec.
  • request parameters is changed from secret map to secret name and namespace.

@mergify mergify bot added the vendor Pull requests that update vendored dependencies label Aug 23, 2022
@mergify mergify bot requested review from nixpanic, yati1998 and Yuggupta27 August 23, 2022 10:16
@Rakshith-R
Copy link
Member Author

I'll follow this up with another pr to make changes to be able to run parallel reconciles,
(including this change would make this pr too large and difficult to review)

@Rakshith-R Rakshith-R requested a review from Madhu-1 August 23, 2022 10:16
This controller has been ported from
https://github.com/csi-addons/volume-replication-operator
with minimal changes required to suit
kubernetes-csi-addons design.
The main changes include:
- tweaks to rbac
- controller now communicates to sidecar
  instead of csi-driver
- sends secret name & ns instead of
  secret data, this will be fed in
  by the sidecar.

Resolves: csi-addons#116

Signed-off-by: Rakshith R <[email protected]>
Signed-off-by: Madhu Rajanna <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Santosh Pillai <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Umanga Chapagain <[email protected]>
Signed-off-by: Shyamsundar Ranganathan <[email protected]>
@mergify mergify bot merged commit 2fc35bb into csi-addons:main Aug 23, 2022
nixpanic pushed a commit to nixpanic/kubernetes-csi-addons that referenced this pull request Nov 15, 2024
…rry-pick-211-to-release-4.17

Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move volume replication operator to kubernetes-csi-addons
3 participants