Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdsec: allow -t to work if using appsec and allowlists #3484

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

blotus
Copy link
Member

@blotus blotus commented Feb 26, 2025

No description provided.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.

Project coverage is 56.63%. Comparing base (c161eb2) to head (c5b4bcd).

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 10.00% 9 Missing ⚠️
pkg/appsec/allowlists/allowlists.go 61.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3484      +/-   ##
==========================================
+ Coverage   56.20%   56.63%   +0.43%     
==========================================
  Files         391      391              
  Lines       43539    43549      +10     
==========================================
+ Hits        24473    24666     +193     
+ Misses      17007    16793     -214     
- Partials     2059     2090      +31     
Flag Coverage Δ
bats 41.00% <16.12%> (+0.89%) ⬆️
unit-linux 33.64% <41.93%> (+0.01%) ⬆️
unit-windows 22.64% <41.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus
Copy link
Member Author

blotus commented Feb 26, 2025

/kind fix
/area appsec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants